Block sending authentication cookies upon 2FA login #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
kasparsd
approved these changes
Dec 7, 2022
dd32
commented
Dec 8, 2022
dd32
commented
Dec 8, 2022
iandunn
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Tested w/ these steps:
- Checkout
master - Add this code to an mu-plugin:
add_filter( 'wp_login', function() { trigger_error( 'test', E_USER_ERROR ); }, 9 );
- Log out, and then back in again with a user who has 2FA enabled. You should see the fatal error.
- inspect cookies in browser, verify they were sent
- Checkout this branch
- Repeat steps and verify they weren't sent
LGTM 👍🏻
15 tasks
Co-authored-by: Ian Dunn <[email protected]>
Co-authored-by: Ian Dunn <[email protected]>
…ecks are included. Co-authored-by: Ian Dunn <[email protected]>
dd32
force-pushed
the
fix/406-alt-block-send_auth_cookies
branch
from
1b78334 to
9527cec
Compare
|
@dd32 is there anything left that's needed to merge this? |
This was
linked to
issues
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback in #406 and limited interest on changing how the login flow works in #490, this PR is a minimal patch which prevents sending the authentication cookies upon hitting the 2FA interstitial page.
As there's limited changes in this PR, this should be easier for others to review and approve.