Improve TOTP autocomplete behaviour #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set autocomplete attribute to 'one-time-code' so browsers and password managers can autocomplete the code if necessary/possible
|
Per yesterday's bug scrub, we're punting this to a future release so we can focus on the U2F deprecation in 0.8.0. |
|
This is great UX improvement and a minimal change so we can merge this in and adjust if necessary based on user feedback. |
kasparsd
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a little improvement over #373 that included the autocomplete attribute. I've set it attribute to 'one-time-code' so browsers and password managers can autocomplete the code if necessary/possible. I've tested it on the latest versions of 1Password and Safari, Chrome, Firefox & Edge and it autocompletes the TOTP code (previously it only worked on Safari)
Great job with the plugin by the way, thanks!