Register scripts before being enqueued

[cojennin]

Registering the fido-u2f-api and fido-u2f-login scripts in the __constructor is generating the following notice:
Notice: wp_register_script was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks.

It seems like these wp_register_script calls should be moved to login_enqueue_assets as that's where they're utilized.

(Props @scottnelle for tracking this down)

[kasparsd]

This looks great, thank you!

[kasparsd]

Looks like this is also referenced here:

two-factor/providers/class.two-factor-fido-u2f-admin.php

Lines 75 to 81 in 2b4ce5c

	wp_enqueue_script(
	'fido-u2f-admin',
	plugins_url( 'js/fido-u2f-admin.js', __FILE__ ),
	array( 'jquery', 'fido-u2f-api' ),
	self::asset_version(),
	true
	);

so we need to make sure this script is registered before it is enqueued there.

[cojennin]

Ah yea, made a change to the PR to register on admin_enqueue_scripts with a lower priority to make sure it gets registered prior to this. But when does login_enqueue_assets get called?

[rinatkhaziev]

Hi @kasparsd ,

Any plans to get this merged in the next release?

[kasparsd]

Fixes #361.

[kasparsd]

There appear to be a few code style issues reported here https://travis-ci.com/github/WordPress/two-factor/jobs/333298974 and a merge conflict with the latest changes introduced by the latest worked merged into master.

Is it OK if I open a new pull request to fix these and also make sure the scripts are available on the login screen?

[kasparsd]

Replacing this with #368 if that's OK.

@rinatkhaziev, @cojennin Could you please code review #368?