Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full RFC6238 Compatibility #207

Closed
wants to merge 175 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
695a61a
Tests: Delete redundant test, add missing one.
iandunn Feb 8, 2023
0d61135
Tests: Ignore view/controller code with minimal coverage value
iandunn Feb 8, 2023
88634af
Backup Codes: Always generate 10 codes via REST.
iandunn Feb 9, 2023
5d91ba6
Tests: Add provider `@group` attributes for convenience.
iandunn Feb 10, 2023
4c9607b
Add rate limiting to two factor attempts. (#510)
dd32 Feb 13, 2023
249e50d
TOTP: Enforce single-use of TOTP one-time passwords. (#517)
dd32 Feb 13, 2023
f7e42d6
Tests: Test for missing user/token more precisely.
iandunn Feb 14, 2023
2991f4c
Include whitespace between the leading text and the code input. (#519)
dd32 Feb 15, 2023
f845b1a
Composer: Install WordPress 6.1.1, always use the latest 6.x version …
dd32 Feb 15, 2023
4bfb2ec
Add unit tests for Two_Factor_Provider::get_code(). (#522)
dd32 Feb 17, 2023
8df5940
Tests: Generate an HTML coverage report when running tests locally.
iandunn Feb 15, 2023
1833492
Core: Reset compromised passwords after 2FA failures (#482)
iandunn Feb 24, 2023
26ee898
Add a TOTP Issuer filter, Document the other TOTP Filters (#530)
dd32 Feb 27, 2023
5ef4cca
Support login-by-email in maybe_show_reset_password_notice(). (#532)
dd32 Feb 28, 2023
917f67a
Switch to using `$_REQUEST` directly instead of `filter_input()` and …
dd32 Mar 2, 2023
5d72721
Be more tolerant of user input for auth codes (#518)
dd32 Mar 3, 2023
eb8567e
Bump loader-utils from 2.0.2 to 2.0.4 (#496)
dependabot[bot] Mar 6, 2023
e1efa02
Bump json5 from 1.0.1 to 1.0.2 (#506)
dependabot[bot] Mar 6, 2023
91bf00f
Bump simple-git from 3.14.1 to 3.16.0 (#508)
dependabot[bot] Mar 6, 2023
4fa4e61
Bump http-cache-semantics from 4.1.0 to 4.1.1 (#512)
dependabot[bot] Mar 6, 2023
f93410a
Bump @sideway/formula from 3.0.0 to 3.0.1 (#513)
dependabot[bot] Mar 6, 2023
aa0da13
Bump webpack from 5.74.0 to 5.76.1
dependabot[bot] Mar 15, 2023
a93ca39
Create 1-bug-report.yml
jeffpaul Mar 15, 2023
3ebfb78
Create 2-enhancement.yml
jeffpaul Mar 15, 2023
5e5233a
Create config.yml
jeffpaul Mar 15, 2023
52663b1
Create PULL_REQUEST_TEMPLATE.md
jeffpaul Mar 15, 2023
3db2103
Standardise on `int|WP_User` input to the "for user" functions (#535)
dd32 Mar 16, 2023
aeaf23f
Merge pull request #539 from WordPress/add/repo-templates
jeffpaul Mar 16, 2023
53c8046
Add information about where to submit security bugs.
felixarntz Mar 16, 2023
c0eae28
Merge pull request #541 from felixarntz/add/faq-security-pointer
peterwilsoncc Mar 16, 2023
9294b1e
version bump to 0.8.0
jeffpaul Mar 20, 2023
e4f0c14
Update .distignore
jeffpaul Mar 20, 2023
a9b5492
Update deploy.yml
jeffpaul Mar 20, 2023
3d350ae
Merge pull request #538 from WordPress/dependabot/npm_and_yarn/webpac…
kasparsd Mar 22, 2023
959b069
Merge branch 'master' into release/0.8.0
kasparsd Mar 22, 2023
75dffb6
Update .github/workflows/deploy.yml
jeffpaul Mar 22, 2023
3801b5d
Update .github/workflows/deploy.yml
jeffpaul Mar 22, 2023
48ce9e4
Merge pull request #543 from WordPress/update/deploy-action
kasparsd Mar 24, 2023
994d139
Merge branch 'master' into release/0.8.0
kasparsd Mar 24, 2023
2fa64f6
Merge pull request #542 from WordPress/release/0.8.0
kasparsd Mar 27, 2023
7d0ffeb
Remove unnecessary comma to fix fatal error on PHP 7.2 (#547)
KZeni Mar 27, 2023
8f73d27
Release `0.8.1` (#550)
iandunn Mar 27, 2023
9e11875
Fix typo
pkevan Mar 29, 2023
fd9a058
Merge pull request #551 from pkevan/patch-2
kasparsd Mar 29, 2023
c490519
Allow filtering the PHP classname used for a provider (#546)
dd32 Apr 12, 2023
ed75664
Bump tested up to version (#552)
av3nger Apr 12, 2023
836ef62
Store the two-factor details in the user session at login time (#528)
dd32 Apr 19, 2023
f027b04
Bump guzzlehttp/psr7 from 2.4.3 to 2.5.0 (#555)
dependabot[bot] Apr 28, 2023
bb96a02
Simplify UI Text / more consistent text and UI. (#521)
dd32 Apr 28, 2023
c725c9b
Use the integer REST API type instead of number, to resolve overly st…
spenserhale May 2, 2023
ff00842
Enqueue jQuery and wp.apiRequest for use within callbacks. (#561)
dd32 May 3, 2023
9032f2d
Revalidate two factor settings prior to allowing any two-factor chang…
dd32 May 11, 2023
654ebb7
2FA revalidation: Avoid prompting for revalidation when the user disa…
dd32 May 17, 2023
98830a9
Sync two-factor session meta to newly created sessions (#574)
dd32 Jun 1, 2023
f21ed3c
Require a nonce be present for revalidate POST requests. (#575)
dd32 Jun 1, 2023
f2227ab
Bump tough-cookie from 4.1.2 to 4.1.3 (#579)
dependabot[bot] Jul 14, 2023
62b677e
Bump word-wrap from 1.2.3 to 1.2.4
dependabot[bot] Jul 19, 2023
237cc2c
Destroy existing sessions when activating 2FA. (#578)
dd32 Sep 4, 2023
5fe5af3
Bump version identifier
dd32 May 22, 2023
2b0d9bc
Add method to disable an individual provider (#587)
iandunn Sep 7, 2023
63d50a7
Bump postcss from 8.4.17 to 8.4.31
dependabot[bot] Oct 7, 2023
e802bd9
Prefer "require_once" in a few spots.
JJJ Feb 29, 2024
7e0d337
Merge pull request #595 from JJJ/issue-594
kasparsd Feb 29, 2024
f033511
Update readme.txt
bph Apr 23, 2024
4bb3180
Merge pull request #597 from bph/patch-1
kasparsd Apr 23, 2024
48840ca
Merge pull request #589 from WordPress/dependabot/npm_and_yarn/postcs…
kasparsd Apr 23, 2024
9d4ce3b
Merge pull request #582 from WordPress/dependabot/npm_and_yarn/word-w…
kasparsd Apr 23, 2024
c1fe518
Bump webpack-dev-middleware from 5.3.3 to 5.3.4
dependabot[bot] Apr 23, 2024
9ff2df3
Bump follow-redirects from 1.15.2 to 1.15.6
dependabot[bot] Apr 23, 2024
5431fc1
Bump @babel/traverse from 7.19.3 to 7.24.1
dependabot[bot] Apr 23, 2024
f64b9c7
Bump the version
kasparsd Apr 23, 2024
b86efd5
Bump the stable tag too
kasparsd Apr 23, 2024
3e377a6
Merge branch 'master' into release/next
kasparsd Apr 23, 2024
dc27957
Merge pull request #603 from WordPress/release/next
kasparsd Apr 25, 2024
7d1c0ec
Bump axios and @wordpress/scripts
dependabot[bot] Apr 25, 2024
b57de23
Merge pull request #602 from WordPress/dependabot/npm_and_yarn/multi-…
kasparsd Apr 25, 2024
15385ca
Merge pull request #601 from WordPress/dependabot/npm_and_yarn/babel/…
kasparsd Apr 25, 2024
8c55686
Merge pull request #600 from WordPress/dependabot/npm_and_yarn/webpac…
kasparsd Apr 25, 2024
88b503c
Merge pull request #599 from WordPress/dependabot/npm_and_yarn/follow…
kasparsd Apr 25, 2024
a0afd35
Remove trailing commas in parameters to avoid syntax error with some …
KZeni Apr 25, 2024
5ec52bb
Merge pull request #604 from KZeni/patch-2
kasparsd Apr 25, 2024
4b30c61
Update linter deps
kasparsd Apr 25, 2024
fa438e9
Check for 5.6+ compat in general
kasparsd Apr 25, 2024
d721235
Ignore test cache everywhere
kasparsd Apr 25, 2024
7abe359
Do lint for PHP compat in general
kasparsd Apr 25, 2024
9d7d3d7
Bump testing to latest too
kasparsd Apr 25, 2024
7bac373
Match the rest of item formatting
kasparsd Apr 25, 2024
e849646
No longer requires starting the environment
kasparsd Apr 25, 2024
bef1d10
Let composer resolve it from vendors
kasparsd Apr 25, 2024
ee518ad
Revert "No longer requires starting the environment"
kasparsd Apr 25, 2024
c385383
Also exclude the build directory
kasparsd Apr 25, 2024
7d543ca
Merge pull request #605 from WordPress/fix-lint-php7
kasparsd Apr 25, 2024
e03bdd3
Bump version
kasparsd Apr 25, 2024
1828c55
Merge pull request #606 from WordPress/release/next
kasparsd Apr 25, 2024
e46cc9a
Rely on just-in-time translation loading
swissspidy Apr 30, 2024
d31431c
Properly define `Requires *` header in main plugin file
swissspidy Apr 30, 2024
66faeef
Merge pull request #608 from swissspidy/fix/load-textdomain
kasparsd Apr 30, 2024
3ddec26
update readme headers
jeffpaul May 8, 2024
c0af398
update plugin headers
jeffpaul May 8, 2024
8eb3461
fix license reference
jeffpaul May 8, 2024
8e70254
Merge pull request #610 from WordPress/update/headers
jeffpaul May 9, 2024
c08f82a
update short description
jeffpaul Jun 12, 2024
cc2c4ad
Merge pull request #612 from WordPress/update/short-desc
jeffpaul Jul 8, 2024
36a749f
Fix typos (#617)
szepeviktor Jul 15, 2024
44f058b
Bump tested up to version to WP 6.6 (#616)
mehul0810 Jul 15, 2024
668ae87
Fix errors reported by PHPStan
szepeviktor Jul 15, 2024
9ac7c2d
More error fixes on level 2
szepeviktor Jul 15, 2024
e5d6b20
Fire an action when a user revalidates their 2FA session. (#620)
dd32 Jul 30, 2024
e0b7ffd
Bump minimum WP to 6.3, minimum PHP to 7.2. (#625)
dd32 Aug 22, 2024
3a0b87b
Remove old grunt deploy related code. See #543 (#627)
dd32 Aug 22, 2024
53042aa
Update how GitHub actions & Unit Testing runs. (#624)
dd32 Aug 22, 2024
595f8b5
Bump axios from 1.6.8 to 1.7.4 (#626)
dependabot[bot] Aug 22, 2024
1cb21ad
Bump braces from 3.0.2 to 3.0.3 (#613)
dependabot[bot] Aug 22, 2024
f468760
Included dev environment doesn't need composer run manually.
dd32 Aug 22, 2024
f1bf362
Bump webpack from 5.91.0 to 5.94.0
dependabot[bot] Aug 31, 2024
cfbfcd2
Merge pull request #628 from WordPress/dependabot/npm_and_yarn/webpac…
dependabot[bot] Sep 10, 2024
71b4931
Update two factor options layout (#623)
thrijith Sep 17, 2024
f1dbd6e
Replace the h3 with a h2, Security keys nests under this.
dd32 Sep 17, 2024
bb048cb
TOTP: Add accessibility for the QR Code, marking it as an image and g…
dd32 Sep 17, 2024
efb96a5
Bump send and express
dependabot[bot] Sep 17, 2024
8141b10
Merge pull request #634 from WordPress/dependabot/npm_and_yarn/multi-…
kasparsd Sep 18, 2024
dbfe715
Be specific about contributors
kasparsd Sep 18, 2024
49a2cc2
Mention 2FA in short description for discoverability
kasparsd Sep 18, 2024
3437c77
Merge pull request #632 from dd32/fix/536
kasparsd Sep 18, 2024
49e410a
Update screenshots to match the current UI
kasparsd Sep 18, 2024
65ea7ad
Merge branch 'master' into phpstan
kasparsd Sep 18, 2024
8405126
Merge pull request #619 from szepeviktor/phpstan
kasparsd Sep 18, 2024
423bb2d
Introduce a helper to return all available two-factor providers (even…
kasparsd Sep 18, 2024
9119613
Let each provider announce the meta keys and options used
kasparsd Sep 18, 2024
8ea9cd3
Keep the same format
kasparsd Sep 18, 2024
129cbfb
Split into dedicated helpers to allow re-use for uninstall and setup
kasparsd Sep 18, 2024
369ead9
Add the actual uninstall hook
kasparsd Sep 18, 2024
638f6d1
Move inline because it isn’t really used anywhere else
kasparsd Sep 18, 2024
f5f75d2
Account for classes being replaced for core providers
kasparsd Sep 18, 2024
6f50ece
Describe the mapping logic
kasparsd Sep 18, 2024
5d3b529
Account for options too
kasparsd Sep 18, 2024
9297b60
Report the meta keys to delete
kasparsd Sep 18, 2024
8d1972f
Add the missing keys
kasparsd Sep 18, 2024
f4d463d
Pull in key name copies when no access otherwise
kasparsd Sep 18, 2024
72ee3e0
Test the uninstall
kasparsd Sep 18, 2024
86bc007
Switch to a core helper
kasparsd Sep 18, 2024
572c288
Add phpstan
kasparsd Sep 18, 2024
ea846be
Ensure the class exists for phpstan
kasparsd Sep 18, 2024
3b1c686
Add a warning for now
kasparsd Sep 18, 2024
d59daca
This test no longer makes sense
kasparsd Sep 18, 2024
acd9e9c
Merge pull request #639 from WordPress/fix-two-factor-options-test
kasparsd Sep 18, 2024
077c220
Merge branch 'master' into 630-fix-uninstall
kasparsd Sep 18, 2024
01a4137
Merge branch 'master' into 618-add-phpstan
kasparsd Sep 18, 2024
fa4212a
Merge branch 'master' into 631-meta-discoverability
kasparsd Sep 18, 2024
04ef5e7
Use the verbose flag to include the error identifier for exclude
kasparsd Sep 18, 2024
7b77277
Version bump
kasparsd Sep 18, 2024
47425c5
Add the PHPstan checks to CI
kasparsd Sep 18, 2024
3f41808
Merge pull request #638 from WordPress/618-add-phpstan
kasparsd Sep 19, 2024
17d3c6c
Merge pull request #636 from WordPress/update-screenshots
kasparsd Sep 19, 2024
642f665
Merge pull request #635 from WordPress/631-meta-discoverability
kasparsd Sep 19, 2024
c152d19
Merge branch 'master' into 630-fix-uninstall
kasparsd Sep 19, 2024
6a95e7f
Merge pull request #637 from WordPress/630-fix-uninstall
kasparsd Sep 19, 2024
de63928
Merge branch 'master' into release/0.9.2
kasparsd Sep 19, 2024
534a14d
Bump to 0.10.0 since we’re changing the profile markup in a potential…
kasparsd Sep 19, 2024
240bcce
Add notices
kasparsd Sep 19, 2024
1225521
Add the default notice as a permanent information
kasparsd Sep 19, 2024
7ce0634
Focus in code input when totp is checked
thrijith Oct 24, 2024
8c029af
Fix typo in selector
thrijith Nov 1, 2024
71112f2
Bump symfony/process from 5.4.40 to 5.4.46
dependabot[bot] Nov 6, 2024
7044dce
Merge pull request #649 from WordPress/dependabot/composer/symfony/pr…
kasparsd Dec 2, 2024
cf57552
Merge branch 'master' into release/0.9.2
kasparsd Dec 2, 2024
d53da74
Keep at minor bump due to dependency changes
kasparsd Dec 2, 2024
990c967
Release 0.10.0
kasparsd Dec 2, 2024
11c97f3
Merge branch 'master' into 485-add-backup-notice
kasparsd Dec 2, 2024
2284d6a
Add additional escaping just in case
kasparsd Dec 2, 2024
100587e
Encourage users to configure a second recovery method
kasparsd Dec 2, 2024
636dc0b
Merge pull request #645 from thrijith/feature/update-ux-totp
kasparsd Dec 2, 2024
3d40c24
Full RFC6238 Compatibility
ericmann Dec 3, 2024
93438be
Port over the RFC reference tests
ericmann Dec 3, 2024
80c6819
Fix Linting Error with ```set_time()`
ericmann Dec 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .distignore
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
.*
# Directories
/node_modules/
/tests/
/vendor/
/node_modules/
/wordpress/
/Gruntfile.js

# Files
.*
/composer.json
/composer.lock
/docker-compose.yml
/Gruntfile.js
/npm-debug.log
/package.json
/package-lock.json
/npm-debug.log
/docker-compose.yml
/readme.md
/phpcs*
/phpunit*
/phpstan.*
/readme.md
/SECURITY.md
72 changes: 72 additions & 0 deletions .github/ISSUE_TEMPLATE/1-bug-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
name: "Bug report"
description: "Report a bug with the Two-Factor plugin for WordPress."
labels: "Bug"
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report! Please fill in as much of the template below as you can. If this is a security issue, please report it in HackerOne instead: https://hackerone.com/wordpress.
- type: textarea
attributes:
label: Describe the bug
description: Please write a clear and concise description of the bug, including what you expect to happen and what is currently happening.
placeholder: |
Feature '...' is not working properly. I expect '...' to happen, but '...' happens instead.
validations:
required: true

- type: textarea
attributes:
label: Steps to Reproduce
description: Please write the steps needed to reproduce the bug.
placeholder: |
1. Go to '...'.
2. Click on '...'.
3. Scroll down to '...'.
4. See error.
validations:
required: true

- type: textarea
attributes:
label: Screenshots, screen recording, code snippet
description: |
If possible, please upload a screenshot or screen recording which demonstrates the bug. You can use LIEcap to create a GIF screen recording: https://www.cockos.com/licecap/
Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in.
For small snippets paste it directly here, or you can use GitHub Gist to share multiple code files: https://gist.github.com
Please ensure the shared code can be used by a developer to reproduce the issue—ideally it can be copied into a local development environment or executed in a browser console to help debug the issue
validations:
required: false

- type: textarea
attributes:
label: Environment information
placeholder: |
- WordPress version and active Theme you are using.
- Browser(s) are you seeing the problem on.
- Device you are using and operating system (e.g. "Desktop with Windows 10", "iPhone with iOS 14", etc.).
validations:
required: false

- type: dropdown
id: existing
attributes:
label: Please confirm that you have searched existing issues in this repository.
description: You can do this by searching https://github.com/WordPress/two-factor/issues and making sure the bug is not related to another plugin.
multiple: true
options:
- 'Yes'
- 'No'
validations:
required: true

- type: dropdown
id: plugins
attributes:
label: Please confirm that you have tested with all plugins deactivated except Two-Factor.
multiple: true
options:
- 'Yes'
- 'No'
validations:
required: true
55 changes: 55 additions & 0 deletions .github/ISSUE_TEMPLATE/2-enhancement.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: "Enhancement"
description: "Suggest an idea for a feature or enhancement to the Two-Factor plugin for WordPress."
labels: "type:enhancement"
body:
- type: markdown
attributes:
value: |
Thank you for suggesting an idea to make things better. Please fill in as much of the template below as you can.
- type: textarea
attributes:
label: Is your enhancement related to a problem? Please describe.
description: Please describe the problem you are trying to solve.
placeholder: |
"I'm always frustrated when ..." or "It is currently difficult to ...".
validations:
required: true

- type: textarea
attributes:
label: Proposed Solution
description: |
Please outline the feature or enhancement that you want and how it addresses any problem identified above.
validations:
required: false

- type: textarea
attributes:
label: Designs
description: |
If applicable, add mockups/screenshots/etc. to help explain your idea.
Tip: You can attach images or videos by clicking this area to highlight it and then dragging files in.
validations:
required: false

- type: textarea
attributes:
label: Describe alternatives you've considered
description: |
Please describe alternative solutions or features you have considered.
placeholder: |
I have also considered `...describe alternative...`, however I feel that my solution described above is better because of `...reason...`.
validations:
required: false

- type: dropdown
id: existing
attributes:
label: Please confirm that you have searched existing issues in this repository.
description: You can do this by searching https://github.com/WordPress/two-factor/issues and making sure the bug is not related to another plugin.
multiple: true
options:
- 'Yes'
- 'No'
validations:
required: true
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: General help request
url: https://wordpress.org/support/plugin/two-factor/
about: For general help requests, create a new topic in the Two-Factor support forum on WordPress.org.
26 changes: 26 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!-- Thanks for contributing to the Two-Factor plugin for WordPress! Filling out this template is required. Any PR that does not include enough information to be reviewed may be closed at a maintainers' discretion. All new code requires documentation and tests to ensure against regressions. -->

## What?
<!-- In a few words, what is the PR actually doing? -->

## Why?
<!-- Why is this PR necessary? What problem is it solving? Reference any existing previous issue(s) or PR(s), but please add a short summary here, too. -->

## How?
<!-- How is your PR addressing the issue at hand? What are the implementation details? -->

## Testing Instructions
<!-- Please provide steps on how to test or validate that the change in this PR works as described. -->

## Screenshots or screencast
<!-- if applicable -->

## Changelog Entry
<!--
Please include a summary for this PR, noting whether this is something being Added / Changed / Deprecated / Removed / Fixed / or Security related. You can replace the sample entries after this comment block with the single changelog entry line for this PR. -->
> Added - New feature.
> Changed - Existing functionality.
> Deprecated - Soon-to-be removed feature.
> Removed - Feature.
> Fixed - Bug fix.
> Security - Vulnerability.
35 changes: 21 additions & 14 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
name: Deploy

# Run deploy only on tag and master builds.
# Run deploy only on published releases.
on:
push:
branches:
- master
release:
types: [published]

Expand Down Expand Up @@ -32,15 +29,25 @@ jobs:
- name: Install NPM dependencies
run: npm install

- name: Authenticate with WordPress.org SVN
run: svn info --non-interactive --username "${{ secrets.SVN_USERNAME }}" --password "${{ secrets.SVN_PASSWORD }}" https://plugins.svn.wordpress.org/two-factor/
- name: Build plugin
run: npm run build

- name: Deploy to WordPress.org SVN
- name: WordPress Plugin Deploy
id: deploy
uses: 10up/action-wordpress-plugin-deploy@stable
with:
generate-zip: true
env:
BUILD_DIR: dist
SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}

- name: Upload release asset
uses: actions/upload-release-asset@v1
env:
DEPLOY_SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
DEPLOY_TRUNK: ${{ contains( github.ref_name, 'master' ) }}
DEPLOY_TAG: ${{ contains( github.ref_type, 'tag' ) }}
DEPLOY_SKIP_CONFIRMATION: true
# Disable deployments while they are failing for unknown reason.
if: env.DEPLOY_SVN_USERNAME && false
run: npm run deploy
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: ${{ steps.deploy.outputs.zip-path }}
asset_name: ${{ github.event.repository.name }}.zip
asset_content_type: application/zip
Loading
Loading