This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Add footer patterns #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess/twentytwentytwo into add/header-block-patterns
kjellr
added
[Type] Enhancement
jffng
reviewed
Oct 11, 2021
| <div class="wp-block-group alignfull" style="padding-top:8rem;padding-bottom:8rem"><!-- wp:columns --> | ||
| <div class="wp-block-columns"><!-- wp:column --> | ||
| <div class="wp-block-column"><!-- wp:paragraph --> | ||
| <p>' . esc_html__( 'ABOUT US', 'twentytwentytwo' ) . '</p> |
There was a problem hiding this comment.
Can these labels be Sentence cased and then "textTransform": uppercase;d?
There was a problem hiding this comment.
I think we should leave them as is for a couple reasons:
- The paragraph block does not have a visible textTransform control. And entering that manually on the block doesn't seem to work in my testing.
- I could switch to a heading block here, but I want these to be set in the system font, and a font choice isn't available for the heading block. (I think this was originally to limit the user to sticking with the theme's styles, but I find it pretty limiting myself... I might open a Gutenberg issue to reconsider that).
For now, I think this is the simplest approach, and will make the most sense to users editing this one.
jffng
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16.
This PR adds the 11 footer patterns from the original mockups.
Thanks @melchoyce for your help building these.
With a couple small exceptions (example), these work fine responsively. If those end up being the only issues people see, I'm comfortable merging this and then fixing the individual patterns in followup issues.
Screenshots