This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Adjust date formats in query patterns #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
jffng
reviewed
Oct 21, 2021
| @@ -13,7 +13,7 @@ | |||
| <!-- wp:group {"layout":{"type":"flex","justifyContent":"space-between"}} --> | |||
| <div class="wp-block-group"><!-- wp:post-title {"isLink":true,"style":{"typography":{"fontFamily":"var:preset|font-family|system-font","fontStyle":"normal","fontWeight":"400"}},"fontSize":"small"} /--> | |||
|
|
|||
| <!-- wp:post-date {"format":"F j, Y","style":{"typography":{"fontStyle":"italic","fontWeight":"400"}},"fontSize":"small"} /--></div> | |||
| <!-- wp:post-date {"format":"m.d.y","style":{"typography":{"fontStyle":"italic","fontWeight":"400"}},"fontSize":"small"} /--></div> | |||
There was a problem hiding this comment.
When there are no featured images, this one looks a little off. But okay to address that in a follow-up.
Default alignment:
Wide alignment:
There was a problem hiding this comment.
Ugh yes, this is an issue the grid view for the query block in general. In any case, this is a non-default layout, and it's called "Image grid posts" so maybe folks won't choose it if it looks bad? 😅
jffng
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two of the checkboxes in #90:
Note that this uses custom (valid) markup in the block to get this to work. When you have one of these selected, the date format dropdown will show an incorrect value. There's an upstream bug filed for that here: WordPress/gutenberg#35854
Screenshots