-
Notifications
You must be signed in to change notification settings - Fork 63
WIP: Update templates to use the new layout setting #121
Conversation
@carolinan When this replacement occurs, do you notice that the previously existing class of |
On a theme of mine, I am replacing this:
With this:
The result is that the original markup of:
Becomes this:
|
Created an issue in case this is a bug: WordPress/gutenberg#43673 |
Yes, I can see the same happening on my local site: |
@mikachan Would you mind echoing this on the Gutenberg issue I created? I feel like this might be a significant bug and would love to see if we can get it fixed and into 14.0 release. |
I've pushed a few commits that I believe cover all the templates. I saw a few merge conflicts with trunk, but these should also be resolved. I think this is ready for another review! |
These look correct to me. |
Update templates to use the new layout setting for container blocks:
"layout":{"type":"constrained"}
: Inner blocks has wide and full width options"layout":{"type":"default"}:
inner blocks do not have wide and full width optionsThese replace
"layout":{"inherit":true} and false
Please feel free to pick a template and add it to the same branch.
Closes #98