Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

WIP: Update templates to use the new layout setting #121

Merged
merged 13 commits into from
Aug 31, 2022

Conversation

carolinan
Copy link
Collaborator

@carolinan carolinan commented Aug 26, 2022

Update templates to use the new layout setting for container blocks:

"layout":{"type":"constrained"} : Inner blocks has wide and full width options
"layout":{"type":"default"}: inner blocks do not have wide and full width options
These replace "layout":{"inherit":true} and false

Please feel free to pick a template and add it to the same branch.

Closes #98

@mikachan mikachan added [Type] Enhancement New feature or request Good First Issue Good for newcomers labels Aug 26, 2022
@bgardner
Copy link

@carolinan When this replacement occurs, do you notice that the previously existing class of is-global-padding disappears?

@bgardner
Copy link

On a theme of mine, I am replacing this:

<!-- wp:post-content {"layout":{"inherit":true}} /-->

With this:

<!-- wp:post-content {"layout":{"type":"constrained"}} /-->

The result is that the original markup of:

<div class="has-global-padding is-layout-constrained entry-content wp-block-post-content">

Becomes this:

<div class="is-layout-constrained entry-content wp-block-post-content">

@bgardner
Copy link

Created an issue in case this is a bug: WordPress/gutenberg#43673

@mikachan
Copy link
Member

When this replacement occurs, do you notice that the previously existing class of is-global-padding disappears?

Yes, I can see the same happening on my local site: is-global-padding is removed.

@bgardner
Copy link

@mikachan Would you mind echoing this on the Gutenberg issue I created? I feel like this might be a significant bug and would love to see if we can get it fixed and into 14.0 release.

@mikachan
Copy link
Member

I've pushed a few commits that I believe cover all the templates. I saw a few merge conflicts with trunk, but these should also be resolved.

I think this is ready for another review!

@carolinan
Copy link
Collaborator Author

These look correct to me.

@mikachan mikachan merged commit fd7eb93 into trunk Aug 31, 2022
@mikachan mikachan deleted the update/layout-setting branch August 31, 2022 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Good for newcomers [Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update layout support
3 participants