Skip to content
This repository has been archived by the owner on Jan 10, 2018. It is now read-only.

Remove deprecated constant HEADER_TEXTCOLOR #27

Closed
grappler opened this issue Sep 10, 2016 · 1 comment · Fixed by #36
Closed

Remove deprecated constant HEADER_TEXTCOLOR #27

grappler opened this issue Sep 10, 2016 · 1 comment · Fixed by #36
Labels
bug pr: ready to merge

Comments

@grappler
Copy link
Member

The constant HEADER_TEXTCOLOR was deprecated in WP 3.4.

Constants are lame. Don't reference them. This is just for backward compatibility.

from /wp-includes/theme.php#L1645

We are adding a check to the new Theme Check to not allow deprecated constants. WPTT/WPThemeReview#30

Related: Automattic/_s#991
@grappler grappler mentioned this issue Sep 10, 2016
Merged
@melchoyce melchoyce added the bug label Sep 10, 2016
@davidakennedy
Copy link
Collaborator

This looks good to me – thanks for the issue and pull request!

davidakennedy added a commit that referenced this issue Sep 20, 2016
@davidakennedy
Merge pull request #36 from grappler/feature/issue-27
2965ec9 
Remove deprecated constant HEADER_TEXTCOLOR.

Fixes #27.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug pr: ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated constant HEADER_TEXTCOLOR
3 participants
@davidakennedy @grappler @melchoyce