Twenty Twenty-One Blocks: Add post meta. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
commented
Nov 4, 2020
| @@ -186,7 +186,7 @@ hr[style*="text-align: right"], | |||
|
|
|||
| hr:not(.is-style-wide):not(.is-style-dots), | |||
| .wp-block-separator:not(.is-style-wide):not(.is-style-dots) { | |||
| max-width: var(--responsive--aligndefault-width); | |||
| max-width: var(--wp--custom--responsive--aligndefault-width); | |||
There was a problem hiding this comment.
I also fixed this variable name — it was incorrect, and was making the separator above the meta display incorrectly.
|
The author block does support the text before (byline), was this left blank intentionally? |
It was — the byline is only set to show up above the author name, not next to it. I'm going to open a GitHub issue for that (as well as for the ability to un-bold the author name) in the Gutenberg repo today. Edit: I added notes to this Gutenberg issue: WordPress/gutenberg#24952 (comment) |
ntsekouras
approved these changes
Nov 6, 2020
Co-authored-by: Nik Tsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds post meta to the footer of posts. For reference, here are the original theme styles for these:
This PR gets somewhat close:
The PR adds this to the bottom of all single post pages, and also to each post in the main query loop. While I was in there, I made the post titles clickable, which makes this all work way better in general. 😄
Example of a post in the main index feed: