Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambitious: Added Query Loop block and updated styling of post meta and navigation blocks #52

Merged
merged 6 commits into from
Oct 22, 2020

Conversation

Netzberufler
Copy link

  • Made some styling fixes for the latest Gutenberg version
  • Made use of the new Query Loop block
  • Changed to a flat file structure in block-template-parts folder

Just a minor update to fix things, before I try out global styles :)

@kjellr
Copy link
Collaborator

kjellr commented Sep 3, 2020

👋 Hi @Netzberufler! I gave this a test, and it's mostly working well. I think there's an issue with one of the template parts though: I'm getting this error on the front end for each single page:

Screen Shot 2020-09-03 at 10 44 30 AM

From a quick look at the code, I think it's looking for an entry-title template, but there isn't one with that name:

<!-- wp:template-part {"slug":"entry-title","theme":"ambitious"} /-->

@@ -31,3 +31,13 @@ <h1 class="has-white-color has-text-color has-text-align-center intro-heading ha
</div>
</div>
<!-- /wp:group -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content above would be great as a block pattern included in the theme, rather than a template part.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I will add that soon. I have already included the pattern for GT Ambition, the existing PHP version of this theme. Works great.

I used the front-page template to see if it could work as some sort of starter content. I'd really like to have some feature to give users a complete page layout rather than a blank page from the start. Patterns are a huge improvement, but still require users to manually discover and insert them. And they work better for smaller sections, not complete pages. WordPress.com has solved this really well with presenting all sorts of block layouts when a new static page is created.

ambitious/block-template-parts/content-page.html Outdated Show resolved Hide resolved
@Netzberufler
Copy link
Author

👋 Hi @Netzberufler! I gave this a test, and it's mostly working well. I think there's an issue with one of the template parts though: I'm getting this error on the front end for each single page:

Screen Shot 2020-09-03 at 10 44 30 AM

From a quick look at the code, I think it's looking for an entry-title template, but there isn't one with that name:

<!-- wp:template-part {"slug":"entry-title","theme":"ambitious"} /-->

Thank you, I missed that. I changed the file structure to make it work in the backend, but it seems subdirectories will be available soon after all :) The ticket was just fixed: WordPress/gutenberg#20375

@jffng
Copy link
Collaborator

jffng commented Oct 22, 2020

I just tested this as of 9.2.1 and it's looking good. Going to merge and follow up with an update to the readme version, thanks @Netzberufler.

@jffng jffng merged commit 26ed514 into WordPress:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants