Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Parisienne up-to-date with Gutenberg 7.9 #38

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Bring Parisienne up-to-date with Gutenberg 7.9 #38

merged 3 commits into from
Jun 22, 2020

Conversation

jffng
Copy link
Collaborator

@jffng jffng commented Apr 14, 2020

This PR makes a few changes:

  • Implements the tagName attribute on group blocks so the markup generated by block templates is semantic: 8f23a85
  • Takes starter content out of demo templates and makes use of block patterns where relevant: 0735d0e
  • Addresses a few stylistic bugs with the header and cover block due to changes in GB:
    dfde44b

How to test:

  • Follow the instructions to spin up a new site, activate Gutenberg + FSE, and the theme
  • Try inserting a block pattern
  • Ensure that the starter pages were created properly

@jffng jffng requested a review from kjellr April 14, 2020 20:58
@jffng jffng self-assigned this Apr 15, 2020
kjellr
kjellr approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@kjellr kjellr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to break anything, so I'm going to merge it for now. At some point, we should bring this up to date with more recent releases though.

@kjellr kjellr merged commit 2abc1c0 into master Jun 22, 2020
@kjellr kjellr deleted the update/parisienne branch June 22, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellr kjellr kjellr approved these changes

Assignees

@jffng jffng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jffng @kjellr