Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parisienne] Pull in block starter content from dedicated directory #25

Closed
wants to merge 3 commits into from

Conversation

jffng
Copy link
Collaborator

@jffng jffng commented Feb 24, 2020

Following #16, this PR separates starter content in the Parisienne theme from block template parts — which should conceptually be reserved for aspects of the site that are used across pages, not demo content or page templates.

To test:

  1. Create a fresh WordPress site
  2. Check out this branch and clone it into your site's themes directory
  3. Install the Gutenberg plugin
  4. Enable the "Full Site Editing" experiment in the Gutenberg > Experiments panel.
  5. Activate Parisienne from within Appearance > Themes.
  6. Go to Customizer and hit Publish
  7. Visit the site and ensure that the Home, About, and Contact pages have loaded with content in each of them.

@jffng jffng requested a review from kjellr February 24, 2020 17:32
@jffng jffng self-assigned this Feb 24, 2020
@jffng jffng added the enhancement New feature or request label Feb 24, 2020
Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Like #16, I think this seems like a decent approach forward, but I'm not totally sure if file_get_contents() is the right implementation. So let's hold off for something else's eyes before we merge. Left one other minor question inline. 👍

parisienne/block-template-parts/header.html Outdated Show resolved Hide resolved
@jffng
Copy link
Collaborator Author

jffng commented Oct 22, 2020

This was a nice thought, but content like this should really exist in a pattern if at all in the theme.

@jffng jffng closed this Oct 22, 2020
@kjellr kjellr deleted the try/parisienne-starter-content-template branch October 22, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants