Support UPDATE LIMIT #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
|
Thank you @kozer! I left a few minor comments but this looks good otherwise. It would also be lovely to add the same support for the DELETE queries if you wouldn't mind? The |
Can we proceed with this one, as we consider it a blocker for Studio release, and open a new ticket for the DELETE statement? |
Co-authored-by: Mukesh Panchal <[email protected]>
|
@kozer nice, getting closer! I went ahead and pushed two failing test cases – let's make sure they work |
…LECT but no WHERE
|
I had an idea how to fix those two test cases so I went ahead and did that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Proposal
Wraps WHERE clauses in UPDATE queries in
rowid in ( SELECT rowid from ...WHERE...)to support MySQL'sLIMITandORDER BYclauses that are unsupported in SQLite.The implementation in
trunkwas throwing an error when this case occurred. ( For example when a user tries to add Woo plugin ).This pr aims to fix that.