Wrap every SQLite query in a transaction #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note this PR isn't targeting the
mainbranch)Description
This PR wraps SQLite query execution in a transaction, or in a nested transaction if one is already in progress.
Why?
Many MySQL queries require more than one SQLite query, for example
ALTER TABLE ADD COLUMN col1 text, ADD COLUMN col1 text. At the moment, the first part of the ALTER query will succeed and the second one will fail – leaving the database in an undefined, broken state. This PR makes SQLite queries as atomic as their MySQL counterparts. They'll either all succeed or all fail.cc @aristath @swissspidy