Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPUnit tests #12

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Fix PHPUnit tests #12

merged 3 commits into from
Feb 28, 2023

Conversation

adamziel
Copy link
Collaborator

The last few commits in #9 broke the unit tests. This PR gets them to work again and adds a phpunit.xml.dist file for convenience:

php ./vendor/bin/phpunit -c ./phpunit.xml.dist                                       1 ↵
PHPUnit 9.6.3 by Sebastian Bergmann and contributors.

.....................................S.................S..I...... 65 / 75 ( 86%)
..........                                                        75 / 75 (100%)

Time: 00:00.533, Memory: 10.00 MB

adamziel
adamziel commented Feb 23, 2023
View reviewed changes
wp-includes/sqlite/class-wp-sqlite-translator.php
@@ -9,8 +9,7 @@
/**
* The queries translator class.
*/
class WP_SQLite_Translator extends PDO {

class WP_SQLite_Translator {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change solves some deprecation errors thrown by PHP.

@adamziel adamziel mentioned this pull request Feb 25, 2023
Merged
@aristath aristath merged commit 22d4481 into main Feb 28, 2023
@aristath aristath deleted the sqlite-translator/use-transactions branch February 28, 2023 12:05
@batonac batonac mentioned this pull request Jul 18, 2023
Closed
@luckormal luckormal mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamziel @aristath