-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-now: improve php tests and comment failing tests #43
Conversation
@sejas I've tried tests locally and they went successfully. I tried uncommenting those from |
…ectory conflict on Mac Os tests
…ound-tools into update/wp-now-php-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great finding @sejas ! We may remove two unnecessary imports from packages/wp-now/src/tests/execute-php.spec.ts
and should be good to go.
…e-use wordpress instance
…date/wp-now-php-tests
@wojtekn Thanks for reviewing it! I moved some php tests to The issue we had was that after the |
Define 'CONCATENATE_SCRIPTS' as false in `wp-config.php` and removes most static assets from the `wp.data` build script. This makes for an incredible size decrease from 44M to 13M. See WordPress#39 and WordPress#2 for more details. Co-authored-by: Adam Zieliński <[email protected]>
What?
Fix tests.
Fix Mac Os wp-cli path error.
Fix php tests after playground mode was introduced.
Testing instrucitons
npx nx test wp-now