Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Environment: Inline images are broken when site starts on a different port #14

Open
adamziel opened this issue May 16, 2023 · 2 comments
Open

Local Environment: Inline images are broken when site starts on a different port #14

adamziel opened this issue May 16, 2023 · 2 comments
Labels
Enhancement New feature or request wp-now

Comments

@adamziel
Copy link
Collaborator

Test:

  1. Start wp-now
  2. Create a post, upload an image, save the post
  3. Display the post
  4. Close wp-now, start on a different port
  5. Confirm the image is still correctly displayed

cc @sejas @danielbachhuber
@adamziel adamziel added the Enhancement New feature or request label May 16, 2023
@danielbachhuber danielbachhuber changed the title Local env test: Reusable content Local Environment: Inline images are broken when site starts on a different port May 16, 2023
@danielbachhuber
Copy link
Member

danielbachhuber commented May 16, 2023 •
edited
Loading

5. Confirm the image is still correctly displayed

The image is broken:

image

The underlying problem is that WordPress stores absolute URLs in the post_content:

<!-- wp:image {"id":6,"sizeSlug":"full","linkDestination":"none"} -->
<figure class="wp-block-image size-full"><img src="http://127.0.0.1:8881/wp-content/uploads/2023/05/28662c0097a9d8029.05331394.jpg" alt="" class="wp-image-6"/></figure>
<!-- /wp:image -->

I'm not sure of a great fix for this. #22 is one potential path forward. Some on-the-fly search-replace could be another option, but that's probably a can of worms.

I captured it as a known issue: #14

@danielbachhuber danielbachhuber mentioned this issue May 16, 2023
Merged
@danielbachhuber danielbachhuber transferred this issue from WordPress/wordpress-playground May 31, 2023
@eliot-akira eliot-akira mentioned this issue Dec 7, 2023
Merged
@ironnysh ironnysh mentioned this issue Apr 17, 2024
Closed
@ironnysh
Copy link
Contributor

ironnysh commented May 1, 2024

That seems to be fixed.

johnhooks pushed a commit to johnhooks/playground-tools that referenced this issue Oct 11, 2024
@adamziel
Migrate to NX-based build (WordPress#151)
d676988 
## Description

Sets up the correct build pipeline for all parts of Playground and PHP.wasm. This enables a public release of the [Playground API](WordPress/wordpress-playground#149) npm package!

I've been [struggling](WordPress/wordpress-playground#146) with [this](WordPress/wordpress-playground#70) for [a while](WordPress/wordpress-playground#150) and couldn't understand what's so hard. NX made it apparent – look at this dependency graph!

<img width="1291" alt="CleanShot 2023-03-16 at 23 16 26@2x" src="https://user-images.githubusercontent.com/205419/225764795-7fa8e972-09f8-41ef-aac2-1c96bd100ea0.png">

No wonder it's been almost impossible to set everything up by hand!

## Usage

Start with `yarn install`

### Shortcuts

To start a copy of `wasm.wordpress.net` locally, run `yarn run dev`.
To build it, run `yarn run build`.

### Fully qualified commands

In reality, these `yarn run` commands are just triggering the underlying project's nx `dev` and `build` commands:

```bash
nx dev playground-website
nx build playground-website
```

Here's a few more interesting commands:

```bash
# Build and run PHP.wasm CLI
nx start php-wasm-cli

# Build latest WordPress releases
nx recompile-wordpress:all playground-remote

# Recompile PHP 5.6 - 8.2 releases to .wasm for web
nx recompile-php:all php-wasm-web

# Recompile PHP 5.6 - 8.2 releases to .wasm for node
nx recompile-php:all php-wasm-node

# Builds markdown files for readthedocs site
nx build docs-site

# Builds the Playground Client npm package
nx build playground-client
```

## NX is the tool Playground needed from the outset

It's ridiculous how many problems this solves:

* The build pipeline is explicitly defined and easy to modify
* Tasks only run once their dependencies are ready
* The dev mode works and is fast
* The build works and is fast
* We get CI checks to confirm the entire build process still works (which solves WordPress#150)
* Cross-package TypeScript just works
* There are linters and formatters (which solves WordPress#14)
* Documentation is correctly generated from the latest built artifacts
* There are nice generators for bootstraping new packages and moving the existing ones around
* There are checks to ensure the private `php-wasm-common` package is not imported by anything else than `php-wasm-web` and `php-wasm-node`

## Next steps

* Add Lerna to harness package publishing
* Additional developer documentation for the nx-based flow

Related to WordPress/wordpress-playground#148 and WordPress/wordpress-playground#147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request wp-now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielbachhuber @adamziel @ironnysh