Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme: Keep search term when changing categories. #674

Open
StevenDufresne opened this issue Apr 16, 2024 · 4 comments
Open

Block theme: Keep search term when changing categories. #674

StevenDufresne opened this issue Apr 16, 2024 · 4 comments
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback [Type] Discussion Proposed idea, needs input from others before actionable

Comments

@StevenDufresne
Copy link
Collaborator

Describe the bug
We don't persist the search term when you change categories. Adding a keyword is a deliberate action that should persist until the user makes the deliberate action to remove it (which I logged an issue for here #673).

Reproduce
Steps to reproduce the behavior:

  1. Go to wp.org/patterns/
  2. Click on "Footers"
  3. Search for "copyright"
  4. Click "All"
  5. Notice the search keyword is no longer applied.

Expected
After clicking "All", I should still be filtering based on the search term.

@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

That's the expected behavior, because you navigate top-down, the filters apply in that order— so you can search within a category or filter within a category or search, but clicking a different category goes back to the "top of the funnel". This pattern was established with Showcase.

@StevenDufresne
Copy link
Collaborator Author

Thinking back, I may have brought this up then as well. 😄

I feel like this needs hands-on user testing. I'll try to find some users to test the showcase and report back.

@alexstine
Copy link

I agree, the flow makes sense. Search context is a search results page.

@StevenDufresne
Copy link
Collaborator Author

If we don't think this is a legitimate concern, should we at least update the breadcrumb to reflect that context?

Currently when I search it goes from:

All Patterns \ Text

to

All Patterns \ Search Results 

Suggestion

All Patterns \ Text

to

All Patterns \ Text \ Search Results

@ryelle ryelle added [Type] Discussion Proposed idea, needs input from others before actionable [Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback [Type] Discussion Proposed idea, needs input from others before actionable
Projects
None yet
Development

No branches or pull requests

3 participants