RN-Mobile: Image block placeholder #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
Mobile App - i.e. Android or iOS
hypest
reviewed
Sep 12, 2018
| @@ -0,0 +1,10 @@ | |||
| /** @format */ | |||
|
|
|||
| import { View, Text } from 'react-native'; | |||
There was a problem hiding this comment.
Well, I noticed one small thing now though: let's add a section header like this one: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/heading/edit.native.js#L6-L9
hypest
reviewed
Sep 12, 2018
| @@ -0,0 +1,10 @@ | |||
| /** @format */ | |||
There was a problem hiding this comment.
Also, let's remove the Prettier pragma since Prettier is not used in the Gutenberg repo/setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a simple mobile version of the Image Block.
This will show a placeholder representing an image block. The UI will be replaced later on.
To test:
This was tested on the mobile Gutenberg project app.
The PR on Mobile Gutenberg is here.