-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression with appender. #9782
Conversation
This PR is a hotfix for a small regression introduced in #9735. Basically the empty "Write your story" placeholder had no top margin, and jumped when clicked. This PR fixes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good to me. No more jumping cursor. 👍
Awesome, thanks so much. Can you approve the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Thanks for the report, @websevendev that looks like a regression. Not of this PR, but a related one. I will take a look. |
This PR is a hotfix for a small regression introduced in #9735. Basically the empty "Write your story" placeholder had no top margin, and jumped when clicked. This PR fixes that.
Before:
After:
Additionally it fixes an issue I think might have regressed with editor styles. The appender height used to be the same as a paragraph height (28px, 56px with margins). But this regressed. This PR adds an explicit height to the appender input field to fix this, noting that a Paragraph is actually a paragraph, whereas the appender is an input field.
☝️ in that GIF I type in "Write your story", then delete the block, then use undo/redo to ensure they look identical