Allow dynamic blocks to create loops #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenland
added
[Type] Enhancement
danielbachhuber
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7427, fixes #8035.
Description
Stores and restores the global post object around dynamic block callbacks. This allows dynamic blocks to create new
WP_Queryinstances and set up its post data, without changing the currently edited post.How has this been tested?
Added a new unit test.
Tested with a custom dynamic block in wp-admin and front-end with the block callback I added in the unit test. I could recreate the scenario described in #7427.
Types of changes
Stores global
$postindo_blocks()and resets it after every dynamic block callback.Checklist: