Update icons for Paragraph, Heading and Subheading for clarity #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the Paragraph heading to an outline version of the paragraph symbol. This is done to fix the confusion where the text-icon looks confusing next to alignments: https://mobile.twitter.com/webmatros/status/1030816482614235137 By using the Paragraph icon, it shows what the block is. This PR also adds new icons for Heading and Subheading, a capital H and smallcap italic H respectively. This is inspired by the same reasons as the "P for Paragraph" argument, H for Heading. Subheading was changed additionally because its previous visual language could also be confused with alignments.
|
Nice, thanks for addressing. I do have concerns with "H" as it doesn't make a lot of sense in most languages and I feel it's too English centric (I know this also corresponds to the HTML tag). It's one where it'd be nice to have localized icons. I do think the "T" works a bit better as the latin root is at least a bit more common across more languages. |
jasmussen
added a commit
that referenced
this pull request
Aug 20, 2018
This refines the recent heading icon change in #9152 (comment), per feedback. Although it is H for Heading, internationally that first letter is not quite as ubiquitous, whereas T fares a bit better. By changing from an H we are also avoiding the very same issue that we sought to address by bringing back the Paragraph icon, namely that there are going to be icons (for heading levels) right next to the switcher, and if they look too alike that might cause confusion.
Merged
|
Oh, shoot, that’s a good point. I didn’t even think of that, sorry.
- Matt (Sent from mobile)
… On 20 Aug 2018, at 12:38, Matias Ventura ***@***.***> wrote:
Nice, thanks for addressing.
I do have concerns with "H" as it doesn't make a lot of sense in most languages and I feel it's too English centric (I know this also corresponds to the HTML tag). It's one where it'd be nice to have localized icons. I do think the "T" works a bit better as the latin root is at least a bit more common across more languages.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
jasmussen
added a commit
that referenced
this pull request
Aug 20, 2018
This refines the recent heading icon change in #9152 (comment), per feedback. Although it is H for Heading, internationally that first letter is not quite as ubiquitous, whereas T fares a bit better. By changing from an H we are also avoiding the very same issue that we sought to address by bringing back the Paragraph icon, namely that there are going to be icons (for heading levels) right next to the switcher, and if they look too alike that might cause confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Paragraph heading to an outline version of the paragraph symbol. This is done to fix the confusion where the text-icon looks confusing next to alignments: https://mobile.twitter.com/webmatros/status/1030816482614235137
By using the Paragraph icon, it shows what the block is.
This PR also adds new icons for Heading and Subheading, a capital H and smallcap italic H respectively. This is inspired by the same reasons as the "P for Paragraph" argument, H for Heading. Subheading was changed additionally because its previous visual language could also be confused with alignments.
Edit: Don't mind the icon that says "Broken" — this was me testing a shared block to try and break something ;)