Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaPlaceholder multiple and gallery properties #9139

Merged
merged 4 commits into from
Aug 24, 2018
Merged

MediaPlaceholder multiple and gallery properties #9139

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d695e29
MediaPlaceholder multiple property
LuigiPulcini Aug 19, 2018
5dcfac1
gallery and playlist check for multiple and type
LuigiPulcini Aug 24, 2018
083edf5
type check when setting the gallery property
LuigiPulcini Aug 24, 2018
74e595c
double to single quotes
LuigiPulcini Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor/src/components/media-placeholder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class MediaPlaceholder extends Component {
{ __( 'Upload' ) }
</FormFileUpload>
<MediaUpload
gallery={ multiple }
gallery={ multiple && type === "image" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an eslint issue here. We should use single quotes. You can test locally using npm run lint or install an eslint plugin for your IDE.

multiple={ multiple }
onSelect={ onSelect }
type={ type }
Expand Down