Framework: Remove client-side document title updates #8831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
danielbachhuber
added
the
Backwards Compatibility
Updated in 417ecf05de7d1734bad950c9d9e36d426844f177 |
It needs to be in a more generic state. Setting the global `$title` overrides the behavior of `get_admin_page_title()` while still letting the value be filterable via `admin_title`.
danielbachhuber
force-pushed
the
remove/document-title
branch
from
417ecf0 to
786de1e
Compare
aduth
commented
Aug 10, 2018
gutenberg.php
Outdated
| @@ -187,6 +189,16 @@ function gutenberg_init( $return, $post ) { | |||
| add_filter( 'screen_options_show_screen', '__return_false' ); | |||
| add_filter( 'admin_body_class', 'gutenberg_add_admin_body_class' ); | |||
|
|
|||
| $post_type_object = get_post_type_object( $post_type ); | |||
| /** | |||
There was a problem hiding this comment.
Should be /*, not /**
Important note: Multi-line comments must not begin with /** (double asterisk) as the parser might mistake it for a DocBlock. Use /* (single asterisk) instead.
danielbachhuber
approved these changes
Aug 10, 2018
|
Failure now is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3702
This pull request seeks to deprecate the
DocumentTitlecomponent and remove its current usage in the editor. This component exists to update the browser tab title on changes to the post's title. With these changes, the title rendered by the server will be used, and will not be manipulated client-side.Testing instructions:
Verify that there are no title changes which occur client-side.
Ensure the title from the server is correct "Edit Post ‹ Site Title — WordPress"