Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Prevent duplicate DotTips from appearing' feedback #8741

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Fix 'Prevent duplicate DotTips from appearing' feedback #8741

merged 2 commits into from
Aug 9, 2018

Conversation

noisysocks
Copy link
Member

Just addressing some feedback that was left on #8642.

@noisysocks noisysocks requested review from talldan and gziolo August 9, 2018 01:42
@gziolo gziolo added this to the 3.5 milestone Aug 9, 2018
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Feature] NUX Anything that impacts the new user experience labels Aug 9, 2018
gziolo
gziolo approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works properly. Thanks for addressing feedback from @talldan 👍

@gziolo gziolo merged commit 93b6ac7 into master Aug 9, 2018
@gziolo gziolo deleted the fix/duplicate-tips-feedback branch August 9, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @gziolo