Add button focus style

[ellatrix]

See #574. Also #520.

[ellatrix]

Noticed that buttons don't have a focus styles while testing tabbing. cc @afercia

[afercia]

Right. Any focusable control should have a focus style, see #574

[jasmussen]

❤️ that you're working on this. It's already much better in this branch.

Design wise — and perhaps @afercia can advise here as well: is it better to have only the focus rectangle to indicate highlight, or would it be good to combine it with something like the hover style also?

[ellatrix]

Might it be good to keep the focus style the same in all of WordPress?

[jasmussen]

Might it be good to keep the focus style the same in all of WordPress?

Absolutely! Good point.

[jasmussen]

It seems like we'll want to do further work in order to fully address #574. But this is a GREAT step in the right direction. Thank you. Let's ship this and iterate.

[ellatrix]

I agree, let's merge and iterate, I mainly just want to see where the focus is now. :)

[aduth]

Should the focus styles have been applied to Button generally, not IconButton specifically?

[ellatrix]

Button already has focus styles, these were for IconButton specifically.

[aduth]

.button has focus styles, but not all Buttons are .buttons

[aduth]

Related: #839

[ellatrix]

Okay, but they don't have these styles in common, so do we want them to share it?

[aduth]

I guess more to the point, we have Buttons in the header which don't currently have focus styles even after these changes:

master:

With f36e1de (#839):

[afercia]

Not sure but the "Preview" is always disabled for me, any flow to follow to make it enabled? Worth noting disabled buttons are not focusable and shouldn't have a focus style.

[jasmussen]

Not sure but the "Preview" is always disabled for me, any flow to follow to make it enabled? Worth noting disabled buttons are not focusable and shouldn't have a focus style.

This is a recent change, you have to save your post before it gets enabled. This is not explicitly the intended behavior, though, and it is subject to iteration. Ideally we'll make it behave exactly as the current preview button works.

[afercia]

This is a recent change, you have to save your post before it gets enabled

Ah ok thanks. Saving is disabled for now so will wait 😉