Avoid block unselection by focus leave #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
force-pushed
the
update/827-block-sticky-focus
branch
from
8c9ba15 to
535b475
Compare
|
Still thinking the focus flows described in #827 are a bit awkwardly defined. We may want to revisit this later as "focus moved to body" or "focus moved to canvas" as unselect intent, rather than escape/click events. I do feel this is an overall improvement though, so going to merge. |
|
Wow, impressive work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #827
Closes #763
This pull request seeks to change the behavior of block selection, tracking selection by focus entering the block, but unselection only by an escape key press or click on the editor canvas (whitespace). It also resolves an issue described in #763 where the area next to the block controls was not considered outside the toolbar (8c9ba15).
Testing instructions:
Ensure that only one block can be selected at a time, either by tabbing into or clicking on the block.
Ensure that a block only becomes unselected when (a) another block becomes selected, (b) the escape key is pressed while focusing a block, or (c) the editor whitespace is clicked.