-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] File Block center align behavior #8303
Conversation
core-blocks/file/editor.scss
Outdated
@@ -4,6 +4,10 @@ | |||
align-items: center; | |||
margin-bottom: 0; | |||
|
|||
> div { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Maybe we can add a class to this div something like wp-block-file__content-wrapper so we can target it using the class name instead of "> div" which is more vulnerable to a regression in a future change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds much better. Addressed in this commit. Thank you ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fix the problem thank you for looking into this problem @nfmohit-wpmudev!
Thank you so much for the review @jorgefilipecosta ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nfmohit-wpmudev!
Thank you so much @noisysocks ❤️ |
Description
This PR addresses #8296 which reports the un-responsive alignment behavior of the file block in the editor when it is set to center align.
How has this been tested?
This PR has been tested by going through the following steps:
This was tested in WP 4.9.7, Gutenberg 3.3.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Screenshots
Types of changes
This PR just adds a bit CSS to the block flexbox element's file child
div
, so that it grows up to the remaining space in the container.Checklist: