Rich Text: Update TinyMCE component to use componentDidUpdate #8148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to update the TinyMCE component to avoid usage of the deprecated
componentWillReceiveProps
React function, which will log warnings when using theReact.StrictMode
component.Implementation notes:
Since this lifecycle method operates on the bound DOM node, it is a fairly straight-forward conversion. In fact, this probably should have been implemented using
componentDidUpdate
all along.There's probably some broader refactoring that could be done here to avoid the manual DOM mutations. This pull request is only meant to address the deprecated lifecycle usage.
Testing instructions:
Verify that there are no regressions in the behavior covered by this method: