Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages: Extract @wordpress/nux package #8016

Merged
merged 4 commits into from
Jul 20, 2018
Merged

Packages: Extract @wordpress/nux package #8016

merged 4 commits into from
Jul 20, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jul 18, 2018

Description

Part of #3955.

This PR extracts new @wordpress/nux package.

How has this been tested?

npm test and make sure there are no regressions.

Make sure you can see the tips when you load new post (make sure you have localstorage cleared before).

@gziolo gziolo added the npm Packages Related to npm packages label Jul 18, 2018
@gziolo gziolo added this to the 3.3 milestone Jul 18, 2018
@gziolo gziolo self-assigned this Jul 18, 2018
@gziolo gziolo requested review from youknowriad, a team and ntwb July 18, 2018 11:14
@Shelob9 Shelob9 mentioned this pull request Jul 18, 2018
Closed
19 tasks
tofumatt
tofumatt reviewed Jul 18, 2018
View reviewed changes
packages/nux/README.md

The NUX module exposes components, and `wp.data` methods useful for onboarding a new user to the WordPress admin interface. Specifically, it exposes _tips_ and _guides_.
The NUX (New User eXperience) module exposes components, and `wp.data` methods useful for onboarding a new user to the WordPress admin interface. Specifically, it exposes _tips_ and _guides_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

tofumatt
tofumatt requested changes Jul 18, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an eslint rule to the .eslintrc that forbids imports from 'nux' and 'nux/*', similar to the other package import rules.

@aduth aduth modified the milestones: 3.3, 3.4 Jul 18, 2018
@gziolo
Copy link
Member Author

gziolo commented Jul 19, 2018 •
edited
Loading

@tofumatt, an eslint rule added with 5236de7.

Edit: There was a similar rule already, I updated to use the more common pattern.

@gziolo gziolo force-pushed the update/nux-package branch from f6829aa to 5236de7 Compare July 19, 2018 07:49
@gziolo gziolo force-pushed the update/nux-package branch from 5236de7 to 1e2cee8 Compare July 19, 2018 09:39
@tofumatt
Copy link
Member

Edit: There was a similar rule already, I updated to use the more common pattern.

Oops, I didn't realise!

@gziolo
Copy link
Member Author

gziolo commented Jul 19, 2018

Thre is still some issue with loading CSS file with this config. I'm looking into it.

@gziolo
Copy link
Member Author

gziolo commented Jul 19, 2018

663f9d1 fixes the issue with missing CSS files. It's not great but should help us move forward with this one. It's exactly the same approach we took when moving components folder in #7640:
https://github.com/WordPress/gutenberg/blob/330a4cf23b3fba073038e4bab041ff612bef09c4/components/index.js

Let's open a follow up PR where we tackle copying CSS files generated by packages build step and add RTL support there, too.

@gziolo gziolo requested a review from gwwar July 19, 2018 14:10
youknowriad
youknowriad approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo modified the milestones: 3.4, 3.3 Jul 20, 2018
@gziolo gziolo merged commit f7a7e6b into master Jul 20, 2018
@gziolo gziolo deleted the update/nux-package branch July 20, 2018 04:45
@gziolo gziolo mentioned this pull request Jul 20, 2018
Closed
@gziolo
Copy link
Member Author

gziolo commented Jul 20, 2018

Opened #8067 to keep track of CSS workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@tofumatt tofumatt tofumatt approved these changes

@ntwb ntwb Awaiting requested review from ntwb

@gwwar gwwar Awaiting requested review from gwwar

Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@gziolo @tofumatt @youknowriad @aduth