Utils: Deprecate buildTermTree function #7976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
Jul 16, 2018
editor/utils/test/terms.js
Outdated
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { buildTermsTree } from '../terms'; |
There was a problem hiding this comment.
Do we really need the test twice?
There was a problem hiding this comment.
In case it diverges, it might make sense.
gziolo
force-pushed
the
update/deprecate-utils-module
branch
from
7c0247a to
53e8f1c
Compare
gziolo
added
the
[Type] Breaking Change
|
I'm curious why this decision was made? Right now we offer a public |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3955.
This PR duplicates
buildTermsTreefunction and puts it closer to the usage. We took this approach to make it possible to get rid ofutilsmodule at all. In the long term, we might want to seek to remove duplication by moving all the logic that build terms tree closer to the data layer which is where it should really happen.As part of this PR we completely deprecate (remove)
wp.utils.buildTermsTree.