Blocks: Tag Cloud

[jahvi]

Description

This is my attempt at implementing the tag cloud widget as a Gutenberg block, it's still a work in progress but I wanted to get some initial feedback while I'm at it.

Continued from #4994.
Fixes #1801.

How has this been tested?

Tested in the latest master branch.

Screenshots

Types of changes

New feature: tag cloud block

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[jahvi]

Updated PR to match changes from #8287

[jahvi]

Any update on this one? I rebased the latest changes from master but not sure if I should refactor anything else.

[Soean]

@jahvi Can you rebase it again? I will test the block on my Gutenberg installation.

[jahvi]

@Soean Sure thing, I just rebased it now.

[karmatosed]

As we focus on phase 1 this will be moving to potential phase 2 and we can then consider it from there, For now, closing and moving to potential blocks for the future.

[jahvi]

Thanks for reopening, I just rebased and fixed some code to match the latest Gutenberg changes. I'm not sure how to fix the CI issues, can you guys advise?

[Soean]

Nice work! You have to delete the generated test files and regenerate them.

Delete:

• core__tag-cloud__showTagCounts.json
• core__tag-cloud__showTagCounts.parsed.json
• core__tag-cloud__showTagCounts.serialized.html
• core__tag-cloud.json
• core__tag-cloud.parsed.json
• core__tag-cloud.serialized.html

Run: GENERATE_MISSING_FIXTURES=y npm run test-unit test/integration/full-content/full-content.spec.js

[melchoyce]

Is the difference just the underlines? We should keep those.

There is also third option available to Tag Cloud widget which I can't see on the block. Not sure what Link Categories is in the first place but it would be worth investigating.

The site you're using probably is old enough that it had the "Links" section in wp-admin (or maybe we include it in development versions?). Links were hidden from all new sites in 3.5. We should conditionally support that, but it's lower priority IMO since it's a deprecated feature. We can make a new issue/PR for that later.

[melchoyce]

Can we also make the error messages change based on which taxonomy is chosen?

No categories to show.
No tags to show.

Or even:

Your site doesn't have any categories to show.
Your site doesn't have any tags to show.

[youknowriad]

I tested this and I feel it's good enough to land to include in Gutenberg 5.1. Follow-up improvements to styling, and messages can happen separately.

[youknowriad]

Thanks everyone for the collaboration and @jahvi Awesome work

[jahvi]

Thanks all for your help, I'll be glad to keep helping improve it.