Block List: Insert blocks after as default block #7870
Conversation
aduth
added
[Type] Bug
aduth
force-pushed
the
update/block-list-as-insert-default
branch
from
a06b1ca to
5980067
Compare
| @@ -657,6 +655,7 @@ const applyWithDispatch = withDispatch( ( dispatch, ownProps ) => { | |||
| blocks = blocks.map( ( block ) => cloneBlock( block, { layout } ) ); | |||
| insertBlocks( blocks, index, rootUID ); | |||
| }, | |||
| onInsertDefaultBlock: insertDefaultBlock, | |||
There was a problem hiding this comment.
I think we should expand onInsertDefaultBlock to correctly pass the rooUID and the index to the action insertDefaultBlock. The action receives attributes, rootUID, and index. We are just passing the index as attributes.
There was a problem hiding this comment.
I noticed two bugs:
Insert 2 image placeholders. Select the first image press enter. The new paragraph is created after the second image. In master, it was created in the middle.
Add a columns block and add an image inside, press enter on the placeholder, the new paragraph is created outside of the columns.
I think both bugs are the result of the problem described in https://github.com/WordPress/gutenberg/pull/7870/files#r201515058.
Avoids issues around focus transitions when moving between code and visual editor†, improves performance. † Worth noting that these are legitimate issues, but ones which shouldn't be "covered" by a utility, but rather as part of its own suite of tests.
aduth
force-pushed
the
update/block-list-as-insert-default
branch
from
5980067 to
8028a7f
Compare
|
Nice catch @jorgefilipecosta . I've pushed a few updates which should fix this. I added a new end-to-end test case, though it doesn't cover much beyond testing the Enter/Delete behaviors while the block focus boundary (e.g. image placeholder) is selected, which is certainly better than what we have. Since I was having some issues implementing it with our current |
Previously getHTMLFromCodeEditor , renamed in #7870 and not accounted for in a rebase
Salvaged from #6452
This pull request seeks to normalize the behavior of
BlockListBlock's "Enter" key handling to insert the default block, not explicitly the paragraph block.Testing instructions:
There should be no change in behavior. Notably, pressing Enter while the Image block placeholder is selected should still insert a paragraph (which is the default block unless otherwise configured).