NUX: Avoid popover refresh on tip mount #7748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6956
This pull request seeks to resolve an issue where end-to-end tests frequently fail due to DotTip mount behavior to refresh its popover positioning. This was meant to be resolved in #7544 and #7493, yet persists. I suspect the bug is due to the fact that
isVisible
changes between the time thesetTimeout
is scheduled and when the callback is reached. The approach here intends to remove thesetTimeout
altogether, resolving the original issue with positioning by ensuring that the post title is rendered immediately. This requires that we change the default behavior ofPostTypeSupportCheck
to assumetrue
if the post type is not yet known. I expect that this is probably the majority case anyways. This may also become a non-issue anyways once #7546 is merged, as the post type data is immediately available, but due to the behavior of resolvers being asynchronous, it doesn't take effect during the initial render.Testing instructions:
localStorage.clear()
in browser console.Ensure end-to-end tests pass:
Ensure unit tests pass: