Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take the unfiltered_html capability from state #7729

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Take the unfiltered_html capability from state #7729

merged 2 commits into from
Jul 10, 2018

Conversation

oandregal
Copy link
Member

Depends on #7667

This PR substitutes the remaining uses of unfiltered_html capability and withAPIData.

We want to deprecate withAPIData soon (#7390 and #7397), and also prevent the direct use of user capabilities in client code (#6361).

@oandregal oandregal mentioned this pull request Jul 5, 2018
Merged
@oandregal oandregal self-assigned this Jul 5, 2018
@oandregal oandregal requested a review from gziolo July 5, 2018 15:48
@oandregal oandregal force-pushed the update/unfiltered-html branch from 49ddf7f to 9b05500 Compare July 5, 2018 15:51
@gziolo
Copy link
Member

gziolo commented Jul 5, 2018

I like this one, will review tomorrow ✨

gziolo
gziolo approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

There is another task that we should do afterwards in a separate PR. We no longer need to use context to pass down canUserUseUnfilteredHTML :)

withContext is another HOC which we might want to deprecate given that it uses old context API from React.

@oandregal oandregal merged commit a3a07b1 into add/html-to-blocks Jul 10, 2018
@oandregal oandregal deleted the update/unfiltered-html branch July 10, 2018 12:39
@oandregal oandregal restored the update/unfiltered-html branch July 10, 2018 12:41
@oandregal oandregal deleted the update/unfiltered-html branch July 10, 2018 12:41
@oandregal oandregal restored the update/unfiltered-html branch July 10, 2018 12:44
@oandregal oandregal deleted the update/unfiltered-html branch July 10, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

@oandregal oandregal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @gziolo