Build: Invert JSX pragma application condition #7701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7493
This pull request seeks to resolve an issue where making changes to a packages file which includes JSX will cause the JSX pragma to not be injected correctly, resulting in errors when reloading the editor after the rebuild completes. This is because the watch task for plugin build runs a rebuild in a subprocess which does not inherit the
TRANSFORM_JSX_PRAGMA
environment variable used to include the plugin necessary for pragma injection.The changes in this pull request invert the condition to a "skip" environment variable, used exclusively in the prebuild step for transpiling the
babel-plugin-import-jsx-pragma
package.Testing instructions:
npm run dev
packages/data/src/index.js
and save the file