Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Regenerate package-lock.json #7641

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Framework: Regenerate package-lock.json #7641

merged 1 commit into from
Jun 29, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Jun 29, 2018

This pull request seeks to effectively revert changes introduced to package-lock.json inadvertently in #7530. It has been regenerated using Node / npm per the version configured by .nvmrc

⇒ nvm use                               
Found '/Users/andrew/Documents/Code/vvv/www/editor/htdocs/wp-content/plugins/gutenberg/.nvmrc' with version <lts/*>
Now using node v8.11.3 (npm v6.1.0)
gutenberg|fix/package-json-differences ⇒

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Jun 29, 2018
@aduth aduth requested a review from jasmussen June 29, 2018 18:17
@aduth aduth mentioned this pull request Jun 29, 2018
Merged
jasmussen
jasmussen approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, sorry. Good thing I have vacation coming up. Thank you.

@aduth
Copy link
Member Author

aduth commented Jun 29, 2018

❤️

@aduth aduth merged commit a89f21e into master Jun 29, 2018
@aduth aduth deleted the fix/package-json-differences branch June 29, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @jasmussen