-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Rename all the hooks moved from blocks to editor #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Feature] Extensibility
The ability to extend blocks or the editing experience
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Jun 20, 2018
gziolo
force-pushed
the
update/editor-hooks
branch
from
June 20, 2018 13:09
ab78cdd
to
de60f7b
Compare
gziolo
changed the title
[WIP] Editor: Rename all the hooks moved from blocks to editor
Editor: Rename all the hooks moved from blocks to editor
Jun 20, 2018
youknowriad
approved these changes
Jun 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was referenced Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Extensibility
The ability to extend blocks or the editing experience
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently moved almost all components from
blocks
module to `editor module. We didn't update the names of all filters and it looks like we should do it for consistency and easier discoverability.This PR fixes it by renaming the following filters and expanding documentation:
blocks.Autocomplete.completers
->editor.Autocomplete.completers
blocks.BlockEdit
->editor.BlockEdit
blocks.BlockListBlock
->editor.BlockListBlock
blocks.MediaUpload
->editor.MediaUpload
TODO
How has this been tested?
I made sure that:
align
feature are still properly aligned in the editorTo test deprecations and doc changes at once. Paste the following snippet which got updated to use old hook:
Made sure it still works and deprecation message appears on the JS console:
Checklist: