Testing: Add e2e tests for Plugins API #7269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Automated Testing
gziolo
force-pushed
the
add/plugins-api-e2e
branch
from
ebcff87 to
08215ad
Compare
youknowriad
approved these changes
Jun 12, 2018
| await toggleMoreMenuItem( 'My title plugin' ); | ||
|
|
||
| const pluginSidebarContent = await page.$eval( '.edit-post-sidebar', ( el ) => el.innerHTML ); | ||
| expect( pluginSidebarContent ).toMatchSnapshot(); |
There was a problem hiding this comment.
Not sure how I feel about snapshotting the whole sidebar? Can't we target something more specific, for example, check that the title changes with the post title in the editor?
There was a problem hiding this comment.
Yes, I will open another PR soon :)
I want more tests!!!
gziolo
added
the
[Feature] Plugins API
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic end-to-end tests for the
PluginSidebarandPluginSidebarMoreMenuItemregistration. I plan to add more tests in this area to make sure other aspects work as expected, as well as other components, they integrate properly.How has this been tested?
npm run test-e2eand Travis verification should be green.Checklist: