Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update/InserterWithShortcuts.opacity: Increased opacity contrast #7208

Closed
wants to merge 1 commit into from
Closed

update/InserterWithShortcuts.opacity: Increased opacity contrast #7208

wants to merge 1 commit into from

Conversation

anevins12
Copy link
Contributor

Description

The opacity and colour has been increased on the InserterWithShortcuts component. Before this change, the component looked disabled where it was actually fully functional.

Resolves #7177

How has this been tested?

  • Passes npm run test

Types of changes

  • CSS changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@aduth aduth added the Needs Design Feedback Needs general design feedback. label Jun 19, 2018
@anevins12 anevins12 mentioned this pull request Jun 24, 2018
Closed
@karmatosed karmatosed self-requested a review July 13, 2018 17:55
karmatosed
karmatosed requested changes Jul 13, 2018
View reviewed changes
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still pass a11y requirements and just have the opacity changed?

@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 11, 2018
@tofumatt
Copy link
Member

Closing this as stale, but if it can be re-visited feel free to re-open this PR or open a new one 😄

@tofumatt tofumatt closed this Nov 16, 2018
@tofumatt tofumatt added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmatosed karmatosed karmatosed requested changes

Assignees
No one assigned
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anevins12 @tofumatt @karmatosed @jasmussen @aduth