Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Andrew feedback #6930

Merged
merged 2 commits into from
May 24, 2018
Merged

Address Andrew feedback #6930

merged 2 commits into from
May 24, 2018

Conversation

jasmussen
Copy link
Contributor

This PR addresses feedback in #6314 (review) and #6496 (review).

Specifically, it:

  • refines the image classes saved
  • moves the TinyMCE table handle styles to the main stylesheet, since they are global
  • cleans up an animation that was astray seemingly

Thank you Andrew, appreciate it!

Joen Asmussen added 2 commits May 24, 2018 08:43
Address feedback for image block
a1f51c7 
This changes the syntax a little bit.
Address feedback fro table block
edbb5a4 
This cleans up where the global table handle styles are stored, and rearranges an animation that seemed astray.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label May 24, 2018
@jasmussen jasmussen self-assigned this May 24, 2018
@jasmussen jasmussen requested a review from aduth May 24, 2018 06:49
aduth
aduth approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jasmussen jasmussen merged commit 3cfaf1d into master May 24, 2018
@jasmussen jasmussen deleted the fix/andrew-feedback branch May 24, 2018 14:53
@jasmussen jasmussen added this to the 3.0 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@jasmussen jasmussen

Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmussen @aduth