Quick Inserter: Restore pattern search and insertion #69028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @xpurichan. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: +7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Feb 6, 2025
|
Thanks for testing, @t-hamano!
Sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #68752.
Partially reverts #67738.
PR restores the ability to search and insert (synced) patterns via Quick Inserter. The patterns only appear in search results when parent blocks allow insertion.
The bug reported in #67693 was caused by a misconfiguration of the
usePatternsStatehook; it was missing theisQuickflag value.Why?
This makes Quick Inserter consistent with block autocompleter.
Testing Instructions
When
allowBlocksis definedWhen any block can be inserted
Testing Instructions for Keyboard
Same.
Screenshots or screencast