Add missing list role to the list of blocks in the global Styles. #69027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/global-styles-block-list-missing-list-role
branch
from
634bfcd to
6949e68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69025
Quick PR to add a missing ARIA role.
What?
Semantically, the list of blocks in Styles > Blocks is a series of list items but it misses a wrapping
list.Why?
This is equivalent to a series of
<li>elements with no wrapping<ul>element and impacts the way screen readers are expected to announce the list itself, the amount of items and position.How?
Adds
role="list"to the wrapping element.Testing Instructions
role="list".Note: if you like and if you use Chrome, you can switch the DOM inspector to the accessibility tree view to better check the correct semantic structure:
Testing Instructions for Keyboard
Screenshots or screencast