Editor: Improve conditions for displaying new page assembler #68852
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jan 23, 2025
| return; | ||
| } | ||
|
|
||
| const isFreshPage = ! isEditedPostDirty() && isEditedPostEmpty(); |
There was a problem hiding this comment.
The effect should react to this state. Check if the page is freshly created when the component is rendered.
|
Size Change: -3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jan 23, 2025
| setIsInserterOpened( { | ||
| tab: 'patterns', | ||
| category: 'core/starter-content', | ||
| } ); | ||
| } | ||
| }, [ postId, shouldEnable, setIsInserterOpened ] ); | ||
| }, [ | ||
| postId, |
There was a problem hiding this comment.
The postId ensures the effect re-runs when the user switches pages in the Site Editor or creates a new page via Command Palette.
|
Flaky tests detected in c898a6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12931643327
|
|
I think this feature should have a really good e2e. It's one of those when regression can annoy the user. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@WordPress/gutenberg-core, this is ready for the review. |
|
I tested the two cases in the instructions and it works as described. |
|
Thank you, @carolinan! Do you mind approving the PR? |
carolinan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #68736.
Solves the following cases when the new page "assembler" shouldn't be displayed (again):
Originally fixed via #54245, but accidentally regressed in #60745. Page creation doesn't use the
auto-draftstatus in the Site Editor, so theisCleanNewPostselector was no longer applicable.Testing Instructions
Instruction one
Instruction two
Testing Instructions for Keyboard
Same.
Screenshots or screencast