Spacer block: Fix dimension control when no spacing presets are available #68818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
stokesman
commented
Jan 22, 2025
Comment on lines
-47
to
-49
| const handleOnChange = ( unprocessedValue ) => { | ||
| onChange( unprocessedValue.all ); | ||
| }; |
|
Size Change: -13 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
6 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If no spacing presets are available then the dimension control is not supposed provide a way to pick from them.
It looks like the problem came about with #61842. In that PR, the method of accessing the presets in the Spacer block’s controls was changed and resulted in there always being at least one preset whereas before it may have been zero. That made the conditional display of a control for no presets unreachable and the control never shown.
Why?
To match the apparent intention of the implementation and improve the UI.
How?
onChangeadapter function only for the control with presets.Testing Instructions
Screenshots or screencast
In these the active theme specifies zero spacing presets:
spacer-single-default-preset-before.mp4
spacer-single-default-preset-after.mp4