Inserter: Remove block default icon from no results message

[SainathPoojary]

Closes: #68688

What?

This PR removes the block default icon from the “No results found” message in the Inserter.

Why?

The icon appears to be a leftover and does not add significant value to the UI. Additionally, it is shown in cases where it feels inappropriate, such as when there are no results for patterns or media. Removing the icon ensures a cleaner and more consistent experience.

How?

The PR removes the component displaying the blockDefault icon from no-results.js in both the block-editor and block-directory packages.

Testing Instructions

1. Open the main Inserter.
2. Search for a non-existing block and verify that only the “No results found” message is displayed, without an icon.
3. Repeat the search for patterns and media, ensuring the same behavior.

Screenshots or screencast

2025-01-16.12-27-44.mp4

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

When you delete a React component, it's a good idea to also delete the CSS selector that the component has.

This means we should be able to remove this style:

gutenberg/packages/block-editor/src/components/inserter/style.scss

Lines 171 to 173 in 36690dc

	.block-editor-inserter__no-results-icon {
	fill: $gray-600;
	}

[SainathPoojary]

Hey @t-hamano,
Thank you for your suggestion. I will raise a follow-up PR shortly to address this.