List View: Use badge component for block anchors #68566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfra
added
[Type] Enhancement
|
Size Change: -10 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 424297e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12706751841
|
Mamaduka
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Thanks, @juanfra!
There seems to be a bug when anchors are too big. This breaks the layout, and block options are no longer displayed.
Try using something like a-very-long-anchor-a-very-long-anchor.
Screencast
CleanShot.2025-01-10.at.11.37.35.mp4
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks, @Mamaduka! Great catch—looks like that happened because the styles were completely removed. I’ve re-added the ones that handle this issue. |
|
Thanks, @juanfra! I'll re-test the PR later today, but besides that issue everything worked correctly ✅ |
Mamaduka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #68020 (It was the last remaining item)
Use the new Badge component for anchors in list view. There's a few minor aesthetic changes when using the badge component styles for the anchors.
I also had to set the text color for the selected state, in order to override the specificity coming from the badge component.
Why?
To improve consistency and sustainability.
How?
Using the new Badge component, removing unused styles.
Testing Instructions
Screenshots or screencast
badge-list-view.mp4