Fix irregular workspace version numbers #68467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
swissspidy
approved these changes
Jan 2, 2025
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7f7482b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12584615302
|
gziolo
added a commit
that referenced
this pull request
Jan 3, 2025
Some packages and dependencies were introduced that do not use the version scheme currently used by Gutenberg for workspace dependencies: `*`. All workspace dependencies in the project should use the same versioning scheme. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: swissspidy <[email protected]> Co-authored-by: gziolo <[email protected]>
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Jan 8, 2025
Some packages and dependencies were introduced that do not use the version scheme currently used by Gutenberg for workspace dependencies: `*`. All workspace dependencies in the project should use the same versioning scheme. --- Co-authored-by: sirreal <[email protected]> Co-authored-by: swissspidy <[email protected]> Co-authored-by: gziolo <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some packages and dependencies were introduced that do not use the version scheme currently used by Gutenberg for workspace dependencies:
*.There is an ongoing issue with published packages where the publishing flow is not correctly replacing the
*dependencies with the correct version numbers, but that is another issue. All workspace dependencies in the project should use the same versioning scheme.Why?
This may help to fix an issue with npm publishing: https://github.com/WordPress/gutenberg/actions/runs/12582973228/job/35069860565
How?
Use the same versioning everywhere.
Testing Instructions
CI is sufficient.