-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: use action.disabled
state to disable actions (primary and secondary)
#68275
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. But I'm curious why did we introduce the action.disabled API in the first place? I mean what are the use-cases?
Flaky tests detected in 45a1d78. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12482690337
|
Right, I don't know what use cases covers a boolean that needs to be resolved at registration time. Having a |
…#68275) Co-authored-by: oandregal <[email protected]> Co-authored-by: youknowriad <[email protected]>
Related #67790 (comment)
What?
This PR uses the existing
disabled
property in the Actions API to disable the action buttons.How?
Pass the
action.disabled
property to the button that renders it.Testing Instructions
disabled: true
to edit.