-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropZone: Make the drop zone in Storybook the same size as the item #68231
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 92cb3a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12467023853
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
…ordPress#68231) * DropZone: Make the drop zone in Storybook the same size as the item * Update changelog * Remove changelog entry Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
By adding
position:relative
to the parent element, make the size of the drop zone component match the size of the item.At the same time, increase the padding a bit because it was a bit cramped when we were about to drop it.
Testing Instructions
Access http://localhost:50240/?path=/story/components-dropzone--default
Screenshots or screencast
Before
before.mp4
After
after.mp4